> -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, July 07, 2014 10:40 PM > To: Gonglei (Arei); Michael S. Tsirkin > Cc: qemu-devel@nongnu.org; afaer...@suse.de; ag...@suse.de; > stefa...@redhat.com; ak...@redhat.com; a...@ozlabs.ru; > alex.william...@redhat.com; arm...@redhat.com; ebl...@redhat.com; > kw...@redhat.com; peter.mayd...@linaro.org; lcapitul...@redhat.com; > pbonz...@redhat.com; kra...@redhat.com; imamm...@redhat.com; > dmi...@daynix.com; marce...@redhat.com; peter.crosthwa...@xilinx.com; > r...@twiddle.net; so...@cmu.edu; Huangweidong (C); Luonengjun; > Huangpeng (Peter); chenliang (T) > Subject: Re: [RFC PATCH 0/5] modify boot order when vm is running > > On 07/07/14 13:12, Gonglei (Arei) wrote: > >> -----Original Message----- > >> From: Laszlo Ersek [mailto:ler...@redhat.com] > >> Sent: Monday, July 07, 2014 6:04 PM > >> To: Michael S. Tsirkin; Gonglei (Arei) > >> Cc: qemu-devel@nongnu.org; afaer...@suse.de; ag...@suse.de; > >> stefa...@redhat.com; ak...@redhat.com; a...@ozlabs.ru; > >> alex.william...@redhat.com; arm...@redhat.com; ebl...@redhat.com; > >> kw...@redhat.com; peter.mayd...@linaro.org; lcapitul...@redhat.com; > >> pbonz...@redhat.com; kra...@redhat.com; imamm...@redhat.com; > >> dmi...@daynix.com; marce...@redhat.com; peter.crosthwa...@xilinx.com; > >> r...@twiddle.net; so...@cmu.edu; Huangweidong (C); Luonengjun; > >> Huangpeng (Peter); chenliang (T) > >> Subject: Re: [RFC PATCH 0/5] modify boot order when vm is running > >> > >> On 07/07/14 11:29, Michael S. Tsirkin wrote: > >>> On Mon, Jul 07, 2014 at 05:10:56PM +0800, arei.gong...@huawei.com > >> wrote: > >>>> From: Chenliang <chenlian...@huawei.com> > >>>> > >>>> Sometime, we want to modify boot order of vm without shutdown it. > >>>> This sets of patches add one qmp to achieve it. And fix some little > >>>> bug when device is hotpluged. > >>>> > >>>> Chenliang (5): > >>>> bootindex: add *_boot_device_path function > >>>> bootindex: reset bootindex when vm reset > >>>> bootindex: delete boot index when device is removed > >>>> bootindex: add qmp to set boot index when vm is running > >>>> bootindex: fix memory leak when ppc sets boot index > >>> > >>> Unfortunately at least for PC, boot order is exposed > >>> in fw cfg which can not change while guest is running. > >>> I suspect we need to change how we report boot order to guests. > >>> While we are at it, maybe we can fix the silly bootindex > >>> convention: I think people really want to specify boot *order*, > >>> not boot index. > >> > >> Please preserve the "bootorder" fw_cfg file, and its format. > >> > >> I don't have any request in relation to the new (== dynamic) feature ATM. > >> > > Sorry, I can't understand your meaning exactly. > > Would you explain it? Thanks! > > I meant that whatever features you introduce, please make sure that a > guest looking for the "bootorder" fw_cfg file will find it, and that the > contents and the format of that fw_cfg file stays the same, for the same > qemu command line options. > Sure.
> I'm not implying that your current series changes the "bootorder" fw_cfg > file (I have not looked at your patches); this is just a general request > I make out of caution. > OK, thanks, Laszlo. > Thanks > Laszlo Best regards, -Gonglei