On Sun, Jul 06, 2014 at 09:42:42AM +0300, Michael S. Tsirkin wrote: > On Fri, Jul 04, 2014 at 09:47:43AM +0200, Paolo Bonzini wrote: > > Il 04/07/2014 09:43, Hu Tao ha scritto: > > >The memory size is rounded up to hpagesize when allocating memory, we > > >can waste at most hpagesize-1 bytes memory. I don't think it's a > > >problem. > > > > > >In the other side, do you think we should give an error in the case like > > >-object memory-backend-ram,size=1111M(given 2M hpagesize)? > > > > I think for gb pages it can make sense to waste a little memory (or even not > > so little, like if you have a 2.5 GB guest). > > > > Paolo > > For 2.1, all we can take at this point is obvious bugfixes. > Propagating error up the stack instead of aborting > might be fine if it's ready before rc1, that is Monday at the latest. > > Afterwards, I'll only merge high priority bugfixes, improving > handling of user errors doesn't count as there's > an easy workaround. > > Whether rounding up to page size is a good idea or not, > I'm inclined to say this is 2.2 material.
I'll send patches not including this part today. Regards, Hu
