> -----Original Message----- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Tuesday, July 01, 2014 8:42 PM > To: Gonglei (Arei) > Cc: QEMU Developers; Anton Ivanov (antivano); Stefan Hajnoczi; Paolo Bonzini; > Huangweidong (C); Luonengjun; chenliang (T) > Subject: Re: [PATCH] net: add mmsghdr struct check for L2TPV3 > > On 1 July 2014 13:23, <arei.gong...@huawei.com> wrote: > > From: Gonglei <arei.gong...@huawei.com> > > > > because mmsghdr struct is introduced on Linux kernel 3.3+. > > add check for mmsghdr, it only gets built on hosts that > > support mmsghdr. > > > +l2tpv3="yes" > > pixman="" > > sdl="" > > sdlabi="1.2" > > @@ -1712,6 +1713,21 @@ else > > fi > > > > ########################################## > > +# L2TPV3 probe > > + > > +if test "$l2tpv3" != "no" ; then > > When can this "if" ever be false? There's no command line > to enable/disable, so you might as well just always run > the compile_prog test and set l2tpv3 to yes or no here > (and then you don't need the initialization above). >
Agreed, thanks! v2 will be posted for a moment. Best regards, -Gonglei
