On Thu, Jun 26, 2014 at 06:33:20PM -0300, Eduardo Habkost wrote:
> We don't support sparse NUMA node IDs yet, so this changes QEMU to
> reject configs where not all nodes are present.
>
> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
> ---
> numa.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/numa.c b/numa.c
> index e93407a..96fe5dd 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -160,9 +160,24 @@ error:
>
> void set_numa_nodes(void)
> {
> + int i;
> +
> + assert(max_numa_nodeid <= MAX_NODES);
> +
> + /* No support for sparse NUMA node IDs yet: */
> + for (i = max_numa_nodeid - 1; i >= 0; i--) {
> + /* Report large node IDs first, to make mistakes easier to spot */
> + if (!numa_info[i].present) {
> + error_report("numa: Node ID missing: %d", i);
> + exit(1);
This reports only one missing node id. Dont' we report all missing ids?
> + }
> + }
> +
> + /* This must be always true if all nodes are present: */
> + assert(nb_numa_nodes == max_numa_nodeid);
> +
> if (nb_numa_nodes > 0) {
> uint64_t numa_total;
> - int i;
>
> if (nb_numa_nodes > MAX_NODES) {
> nb_numa_nodes = MAX_NODES;
> --
> 1.9.3
