On Thu, Jun 26, 2014 at 09:06:03AM -0600, Eric Blake wrote: > On 06/23/2014 06:32 AM, Chrysostomos Nanakos wrote: > > VM Image on Archipelago volume is specified like this: > > > > file=archipelago:<volumename>[/mport=<mapperd_port>[:vport=<vlmcd_port>][: > > segment=<segment_name>]] > > > > or > > > > file.driver=archipelago,file.volume=<volumename>[,file.mport=<mapperd_port>[, > > file.vport=<vlmcd_port>][,file.segment=<segment_name>]] > > > > I still plan to review this series in full, but my quick pre-review comment: > > on version 2, Markus suggested that you should separate the patch that > adds QMP structured options (first) from the patch that adds syntactic > sugar > file=archipelago:<volumename>[/mport=<mapperd_port>[:vport=<vlmcd_port>]] > (second) > > https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00269.html > > and I stand by his suggestion, although I don't see that split here yet. > A new patch series (v6) will be submitted ASAP, splitting QMP structured options and syntactic sugar as suggested.
Thanks!