On 06/25/2014 08:35 AM, Kevin Wolf wrote: > The idea of bdrv_fill_options() is to convert every parameter for > opening images, in particular the filename and flags, to entries in the > options QDict. > > This patch starts with moving the filename parsing and driver probing > part from bdrv_file_open() to the new function. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block.c | 112 > +++++++++++++++++++++++++++++++++++++++------------------------- > 1 file changed, 69 insertions(+), 43 deletions(-) > > + * Fills in default options for opening images and converts the legacy > + * filename/flags pair to option QDict entries. > */ > -static int bdrv_file_open(BlockDriverState *bs, const char *filename, > - QDict **options, int flags, Error **errp) > +static int bdrv_fill_options(QDict **options, const char *filename, > + Error **errp)
Still looks odd to reference filename/flags pair in the comments when there is no flags argument, but it gets fixed later in the series so I can overlook it. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
