Am 20.06.2014 12:58, schrieb Aurelien Jarno: > Thanks for this new version, I'll apply it in the next days unless > someone comes with good arguments why we should not do that. > > Reviewed-by: Aurelien Jarno <aurel...@aurel32.net>
No objection to the code, I just think that "hw/mips:" is redundant in the subject, although there's no precedent yet. http://git.qemu-project.org/?p=qemu.git;a=history;f=hw/mips/gt64xxx_pci.c;h=6398514c99d2b15cd047149c8457717e352e9347;hb=HEAD Same applies to the other MIPS patch. Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg