On 18 June 2014 16:37, Alexander Graf <ag...@suse.de> wrote: > I actually agree with Greg here. We implicitly create different VGA adapters > today depending on TARGET_WORDS_BIGENDIAN. The FB endianness should have > been separate devices (BE / LE) or runtime configuration from the beginning. > > Anything that checks TARGET_WORDS_BIGENDIAN in hw/ is very likely to do > something pretty wrong ;).
Directly, yes, it's a bit of a red flag. But a huge % of devices do indirectly, by marking their memory regions as DEVICE_NATIVE_ENDIAN. thanks -- PMM