On 06/10/2014 05:25 AM, Amos Kong wrote: > It's ugly to add const prefix for parameter type by an if statement > outside c_type(). This patch adds a parameter to do it. > > Signed-off-by: Amos Kong <ak...@redhat.com> > Suggested-by: Markus Armbruster <arm...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > Reviewed-by: Markus Armbruster <arm...@redhat.com> > --- > scripts/qapi-commands.py | 4 +--- > scripts/qapi.py | 4 +++- > 2 files changed, 4 insertions(+), 4 deletions(-)
Wenchao's series introduces another client that needs this treatment: https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg01225.html Depending on what order things get merged in, you may need followup patches or conflict resolution. > > diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py > index 7d93d01..34f200a 100644 > --- a/scripts/qapi-commands.py > +++ b/scripts/qapi-commands.py > @@ -29,9 +29,7 @@ def type_visitor(name): > def generate_command_decl(name, args, ret_type): > arglist="" > for argname, argtype, optional, structured in parse_args(args): > - argtype = c_type(argtype) > - if argtype == "char *": > - argtype = "const char *" > + argtype = c_type(argtype, is_param=True) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
