-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Amos,
Am 17.06.2014 14:54, schrieb Amos Kong: > On Mon, Jun 09, 2014 at 03:22:51PM +0200, Stefan Hajnoczi wrote: >> On Fri, Jun 06, 2014 at 10:33:49PM +0800, Amos Kong wrote: >>> It's worth to add a hotplug test to qtest, but without >>> cooperation of guest OS, new devices can't be initialized by >>> guest, and hot-unplug doesn't work. >>> >>> However, the new test can cover some part of code of >>> hotplug/unplug. >>> >>> I will write another subtest to test hotplug with pci support. >>> >>> V2: move qmp_exec_hmp_cmd() to libqtest.c excape hmp cmd >>> (stefanha) use qmp_exec_hmp_cmd() in blockdev-test V3: use >>> vp_list to format string, free escaped string V4: free escaped >>> string by g_free() > > Hi Andreas, > > Can you apply this patchset to your tree? Sorry for the late reply, I was on vacation and am still fighting a mail backlog... I had a question about the new HMP helper function - I see in 4/4 that drive_add was already being done via HMP, so I guess that's the culprit, but still I wonder whether we can do device-add via QMP. That said, I've reviewed the generic qtest part OK, and would assume virtio-blk-test (you can drop the .c in the topic please) to go through the same tree virtio-blk does, so via Stefan/Kevin. Regards, Andreas - -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJToESEAAoJEPou0S0+fgE/fbAP/Ainb27oOKTtkQwslqWeFWrq p/HS+IJ/mw1FJl7THu0lH9nUtSUhxf86sWa0zU1q7EYmc0Pl/ZqxZnK28R9ebsVg 5Fkij4Ze6nPwngbu8vOJ1DiI6yjxQfEteZpt3vS3ThtE8A1lC1iM5htiNdFsfCgj 08C7NR4+jQUGKZlSXtRYfdAR/LHyS7vtFscxCx4k4Erx3+R5hXbdFovkXz31PbJI rn439DeQTnkpBNmfr/S6S74WSKAwhZASOKN+d0jJ+RIjAqU/bFZEhE6LPsZ/MnVg GD2MZl+diLk44nr66BCK3Q/qiNS8rkSZ9UgvCo1SuwgSeo48f4MAtrEDfP0QS3Kz zo+nHkHtJlfWvbGC2US2xaHAaeQU/JpNa+dr5PBcM6Bwj5d1xQ2TVJmid7UzhZEC eB3KL5Za8gYIkzRBZqfH4cpiaABC8SFBu90ACmFMxRAydOqlK7fOXK761gGcaaif 1JJ0qk4InWG3PBR0N/YWX14nik5SdCsAcnjoulLuxSZ2HtJ3Rz3e4yII0qdjQsmB NMp9vLIVY+YlOwD2qzCS+4JOxkKlEF9fplsNwxelOKv28Ge2WCwcgiOySiVghUqn cVNpPrP7jgALFHMlnbQomyvT7Cu9GoF0ScJO3IpAXManSQ5j8BaDxkt3ZbwiT5kT ixvewd2AeNN9o/q1mZWq =9qZC -----END PGP SIGNATURE-----
