On Mon, Jun 16, 2014 at 06:33:42PM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov <imamm...@redhat.com>
Note that properties are all int64. I think we need a new kind of "RAM offset" property that verifies that the supplied value is a valid ram offset. > --- > hw/i386/pc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 73daa07..e993b0f 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1564,8 +1564,8 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev, > PCDIMMDevice *dimm = PC_DIMM(dev); > PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm); > MemoryRegion *mr = ddc->get_memory_region(dimm); > - ram_addr_t addr = object_property_get_int(OBJECT(dimm), > PC_DIMM_ADDR_PROP, > - &local_err); > + uint64_t addr = object_property_get_int(OBJECT(dimm), PC_DIMM_ADDR_PROP, > + &local_err); > if (local_err) { > goto out; > } > -- > 1.7.1