On 17 June 2014 11:45, Gerd Hoffmann <kra...@redhat.com> wrote: > Benjamin Herrenschmidt wrote: >> What do you prefer ? > > Let pixman handle it? Well, except that pixman can't handle byteswapped > 16bpp formats. Too bad :( > > In any case cleaning up the whole mess is overdue and doing that > beforehand should simplify the job alot. For quite some time qemu uses > 32bpp internally no matter what, so the functions for converting the > guest's framebuffer into anything but 32bpp should be dead code.
Slight tangent, but is there an example in-tree of a framebuffer model which uses pixman for the pixel conversion? The -template.h stuff looks quite ugly, not to mention repetitive across devices, but I don't really feel confident about trying to update existing ARM devices (eg the pl110) without a sample to use as inspiration... thanks -- PMM
