On Tue, Jun 17, 2014 at 04:47:53PM +0800, Hu Tao wrote: > On Mon, Jun 16, 2014 at 02:09:33PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jun 16, 2014 at 06:05:40PM +0800, Hu Tao wrote: > > > Michael, > > > > > > This is fixes for your pci tree v2. please review. thanks! > > > > Patches 1,4 applied. Thanks! > > What about patches 2,3? If you need I can resend patch 2 based on Igor's > comments. About patch 3, I assume you leave it as it is not a > regression.
Patch 2 isn't a regression either, right? Please go ahead and repost patches 2,3 addressing comments. They are unrelated so don't have to be in a series, even. > > > > > changes to v1: > > > > > > 1. adds the missing query-memdev and change into querying qom for > > > memdevs(patch 1) > > > 2. tweak error message (patch 2) > > > 3. improve error handling for memory-backend-file (patch 3) > > > 4. fixup the problem that nodes not start from 0 (patch 4) > > > > > > Hu Tao (4): > > > qmp: add query-memdev > > > check if we have space left for hotplugged memory > > > memory-backend-file: improve error handling > > > fixup! numa: add -numa node,memdev= option > > > > > > exec.c | 26 ++++++++++++----- > > > hw/mem/pc-dimm.c | 7 +++++ > > > numa.c | 89 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++- > > > qapi-schema.json | 40 +++++++++++++++++++++++++ > > > qmp-commands.hx | 38 ++++++++++++++++++++++++ > > > 5 files changed, 191 insertions(+), 9 deletions(-) > > > > > > -- > > > 1.9.3
