Pierre Riteau <pierre.rit...@irisa.fr> wrote on 21/01/2010 20:03:32:
> On 21 janv. 2010, at 16:24, Liran Schour wrote: > > > Move to stage3 only when remaining work can be done below max downtime. > > > > Changes from v1: remove max iterations. Try to infer storage > performance and by that calculate remaining work. ... > > I haven't read the patch in detail but I think we should be able to > avoid duplicating code from vl.c by using qemu_get_clock. > Also, is floating point really necessary? I thought that qemu_get_clock will return a value in 1000HZ (and that is too low resolution). But now I see that I can use qemu_get_clock (host_clock) and get nanoseconds resolution. I will switch it to qemu_get_clock(host_clock) to avoid duplicating of code. And I think we can avoid floating point here. Thanks for the review, - Liran