On 06/12/2014 11:46 AM, Eric Blake wrote: > On 06/11/2014 06:10 PM, Alexey Kardashevskiy wrote: > >>>> + * This program is free software; you can redistribute it and/or modify >>>> + * it under the terms of the GNU General Public License as published by >>>> + * the Free Software Foundation; either version 2 of the License, >>>> + * or (at your option) any later version. > >>> >>> For the GPL license to work, there has to be a Copyright line. >> >> Hm. Ok. include/hw/fw-path-provider.h (where I copied this from) does not >> have one and it was ok. > > Just because there's existing bad practice in the code base doesn't mean > new files should perpetuate it :)
Paolo did that in the first place and if he does it, I assume this is at least not "bad" ;) Like this? I do not know what should be there, corporation or something or just me? --- a/hw/core/nmi.c +++ b/hw/core/nmi.c @@ -1,6 +1,8 @@ /* * NMI monitor handler class and helpers. * + * Copyright (c) 2014 Alexey Kardashevskiy <a...@ozlabs.ru> + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, -- Alexey
