Eric Blake <ebl...@redhat.com> writes:

> On 06/06/2014 10:47 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>>  ui/vnc-tls.c |  6 ++----
>>  ui/vnc.c     | 12 ++++--------
>>  2 files changed, 6 insertions(+), 12 deletions(-)
>> 
>> diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c
>> index 50275de..6392326 100644
>> --- a/ui/vnc-tls.c
>> +++ b/ui/vnc-tls.c
>> @@ -443,10 +443,8 @@ static int vnc_set_x509_credential(VncDisplay *vd,
>>  {
>>      struct stat sb;
>>  
>> -    if (*cred) {
>> -        g_free(*cred);
>> -        *cred = NULL;
>> -    }
>> +    g_free(*cred);
>> +    *cred = NULL;
>>  
>>      *cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
>
> Still a dead store

No deader than before my patch :)

Still, it's as good an opportunity to drop it as any.  Gerd, would you
like a v3?

Reply via email to