On 05/07/2014 03:58 AM, Chunyan Liu wrote: > Signed-off-by: Dong Xu Wang <wdon...@linux.vnet.ibm.com> > Signed-off-by: Chunyan Liu <cy...@suse.com> > --- > Changes: > * remove exporting qemu_opt_find from qcow2 patch and commit separately. > * remove unnecessary indention changes in bdrv_qcow2 as Eric points out. > > block/qcow2.c | 261 > +++++++++++++++++++++++++++++++--------------------------- > 1 file changed, 139 insertions(+), 122 deletions(-) >
> } else {
> - fprintf(stderr, "Unknown compatibility level %s.\n",
> - options[i].value.s);
> + fprintf(stderr, "Unknown compatibility level %s.\n", compat);
Not your fault this is using fprintf instead of error_report. But may
be worth a followup patch to start converting this file to use common
error reporting practices. Since this suggestion doesn't affect the
validaty of this series...
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
