On Wed, Jun 04, 2014 at 10:47:21PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 02, 2014 at 01:13:18PM -0400, Gabriel L. Somlo wrote: > > Hi, > > > > On Mon, May 19, 2014 at 10:44:48PM +0300, Michael S. Tsirkin wrote: > > > On Mon, May 19, 2014 at 10:09:52AM -0400, Gabriel L. Somlo wrote: > > > > Changelog: > > > > > > > > new in v4: > > > > - slightly improved commit blurbs > > > > > > > > v3: > > > > - endian-ness fix (1/3) now correctly handles cpuid version and > > > > features > > > > - included documentation (qemu-options.hx) for type 0 uefi flag (2/3) > > > > - fixed type 17 field sizes ("word" means 16 bits, not 32 :) :) > > > > > > > > > > > > v2: > > > > - fix endian-ness for *all* larger-than-8bit fields (patch 1/2) > > > > - resubmit type0 update (2/2) with appropriate endian-ness fix > > > > for 64-bit field. > > > > > > > > > > Thanks! > > > > http://patchwork.ozlabs.org/patch/350248/ > > http://patchwork.ozlabs.org/patch/350253/ > > http://patchwork.ozlabs.org/patch/350252/ > > > > Not sure where we left this, was somebody going to pull these, or are > > we waiting for the unit tests: > > > > > One question: we don't seem to have unit-test for this > > > interface in qemu, do we? > > > I would like to see at least a basic test along the lines of > > > tests/acpi-test.c: run bios to load tables from QEMU, > > > then do some basic checks on the tables that bios loaded. > > > > ... in which case: > > > > http://patchwork.ozlabs.org/patch/353072/ > > http://patchwork.ozlabs.org/patch/353073/ > > > > Wondering if I should send out another series containing all five, or > > if the first three are already "accepted", in which case "ping" only > > on the latter two :) > > > > Thanks much, > > --Gabriel > > > Also pls confirm everything necessary is there in my tree: > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
Looks good ! Thanks, --Gabriel