On Tue, Jun 03, 2014 at 03:37:29PM +0200, Paolo Bonzini wrote: > > QEMUIOVector *inhdr; /* iovecs for virtio_blk_inhdr */ > > This can be unified with the "in" field; the status is only one byte, so > using a full-blown QEMUIOVector is overkill. Stefan, what do you think?
I thought about this when initially writing the code, but it seemed like a hack to assume virtio_blk_inhdr will always be 1 byte. virtio-blk is unlikely to change much since the focus is on virtio-scsi rather than piling on more virtio-blk feature. I still prefer we treat it like a struct without making size assumptions, but if the code turns out to be nicer then I don't mind. Stefan
