Il 02/06/2014 18:17, Peter Maydell ha scritto:
Um. This feels like we're wrongly overloading this flag for more than one thing. "Is the user-mode binary BE8?" is definitely not a property of the CPU, so it shouldn't be a CPU state flag. (Conversely, "is the iside endianness the opposite way round to TARGET_WORDS_BIGENDIAN" is a CPU property of sorts.) It seems to me that we probably want to fix this by more correctly modelling the actual CPU state involved here, by having user-mode either set or not set SCTLR.B [set only if BE32 binary], and the data and insn fetches honour both that and CPSR.E appropriately.)
So basically it's s/bswap_code/!sctlr_b/. Thanks for the suggestion! Paolo