On 05/31/2014 05:50 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet <ben...@irqsave.net> > --- > qapi-schema.json | 22 ---------------------- > qapi/block-core.json | 22 ++++++++++++++++++++++ > 2 files changed, 22 insertions(+), 22 deletions(-)
7-20: Reviewed-by: Eric Blake <ebl...@redhat.com> And yes, I really do think this is too fine of a split. It would have been faster for me to do a review of a single patch covering all structs moved to block-core.json in one go than it is to review lots of tiny piecemeal patches (as I mentioned in the RFC, it is very easy to do a review-by-sed for large code motion patches, as long as the code moved maintains its relative ordering between the old and new files: https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg06116.html - what I was complaining about there was that you had one patch with changes intermixed into three files, so the code motion no longer had a relative ordering between deletion and insertion lines). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
