On Mon, 18 Jan 2010 12:23:28 -0200 Luiz Capitulino <lcapitul...@redhat.com> wrote:
> On Fri, 15 Jan 2010 17:25:25 +0100 > Markus Armbruster <arm...@redhat.com> wrote: > > > > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > > --- > > qerror.c | 4 ++++ > > qerror.h | 3 +++ > > 2 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/qerror.c b/qerror.c > > index 5f8fc5d..e7b8ca7 100644 > > --- a/qerror.c > > +++ b/qerror.c > > @@ -73,6 +73,10 @@ static const QErrorStringTable qerror_table[] = { > > .desc = "No file descriptor supplied via SCM_RIGHTS", > > }, > > { > > + .error_fmt = QERR_FOPEN_FAILED, > > + .desc = "Could not open '%{filename}'", > > + }, > > Shouldn't this be something like QERR_OPEN_FAILED, so that we > can use the same error for all open functions? Something I forgot to mention, 'FopenFailed' doesn't seem interesting to clients. Maybe 'OpenFileFailed'?