On Sun, Jan 17, 2010, Stefan Weil wrote: > > On systems were sdl-config isn't installed, ./configure triggers this > > warning: > > ./configure: 957: sdl-config: not found > > which version did you test? > Git master has no sdl-config call at configure:957. > > But I get warning messages, too, when pkg-config or > sdl-config are missing.
Yes, the line is bogus for me as well; not sure why. I'm using master. > Your patch fixes the warning for sdl-config and sets > sdl=no. If configure was called with --enable-sdl, > this solution is wrong: configure should abort with > an error message (feature_not_found). Ack; how about the attached one instead? -- Loïc Minier
>From eb4ba45b0d71d13cb89f6362443ffbe50b65eba0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Minier?= <l...@dooz.org> Date: Sun, 17 Jan 2010 13:42:04 +0100 Subject: [PATCH] Check for sdl-config before calling it MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Check whether sdl-config is available before calling it, otherwise ./configure triggers a warning: ./configure: 957: sdl-config: not found If neither the .pc file not sdl-config are present, disable SDL support. Signed-off-by: Loïc Minier <l...@dooz.org> --- configure | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 5631bbb..baa2800 100755 --- a/configure +++ b/configure @@ -993,9 +993,14 @@ fi if $pkgconfig sdl --modversion >/dev/null 2>&1; then sdlconfig="$pkgconfig sdl" _sdlversion=`$sdlconfig --modversion 2>/dev/null | sed 's/[^0-9]//g'` -else +elif which sdl-config >/dev/null 2>&1; then sdlconfig='sdl-config' _sdlversion=`$sdlconfig --version | sed 's/[^0-9]//g'` +else + if test "$sdl" = "yes" ; then + feature_not_found "sdl" + fi + sdl=no fi sdl_too_old=no -- 1.6.5