On 05/22/2014 08:47 PM, Alexander Graf wrote: > > On 21.05.14 17:21, Alexey Kardashevskiy wrote: >> At the moment the "ibm,hypertas-functions" list is fixed. However some >> calls should be listed there if they are supported by QEMU or the host >> kernel. >> >> This enables hyperrtas_prop to grow on stack by adding >> a SPAPR_HYPERRTAS_ADD macro. "qemu,hypertas-functions" is converted as well. >> >> The first user of this is going to be a "multi-tce" property. >> >> Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> >> --- >> Changes: >> v2: >> * replaced alloca() with GString >> --- >> hw/ppc/spapr.c | 30 +++++++++++++++++++++++------- >> 1 file changed, 23 insertions(+), 7 deletions(-) >> >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> index 0a61246..3b28211 100644 >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -293,6 +293,10 @@ static size_t create_page_sizes_prop(CPUPPCState >> *env, uint32_t *prop, >> } \ >> } while (0) >> +static inline void add_str(GString *s, const gchar *s1) > > Please remove the "inline" :). Otherwise this looks a lot nicer than before :)
Good :) What now? Have you finished with this set and I can repost it? -- Alexey