-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 14/05/14 13:02, Eric Blake wrote: > On 05/14/2014 10:06 AM, Matthew Booth wrote: > >>>> The new syntax is: >>>> >>>> http://user:passw...@example.com/path?query[opt1=val:opt2=val] >>>> > >>>> >> >> A URI can, by definition, contain a query string, and we cannot >> assume that it won't. In fact, the use case I'm specifically >> interested in always includes a query string. If we try to >> overload the query string, we're adding heuristic fuzziness. My >> syntax makes the option string distinct from the URI, so no >> heuristics are required. It's also very clear to read IMHO. > > But your proposed syntax is no longer a URI. I'd much rather see: > > 'json:{"driver":"curl","filename":"http://user:passw...@example.com/path?query","opt1":"val","opt2":"val"}' > > which then shares the same syntax as all other drivers for > creating a flat string that encodes multiple pieces of information, > rather than having to overload the filename to be a non-URI > encoding locally useful information. >
Agree: if it's possible to pass explicit parameters to a backing file then we should ditch the hokey parsing. I'll check out the new syntax, rip out the parser and update the docs. Matt - -- Matthew Booth Red Hat Engineering, Virtualisation Team Phone: +442070094448 (UK) GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlNz1f4ACgkQNEHqGdM8NJBQ8ACfeekpMvSJS0kh1sx+/gtT6lS6 nwgAn2yxW2ympFXfvTybxQhBfdL907Cc =HDQu -----END PGP SIGNATURE-----
