Hi, any feedback about this version? http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg01098.html http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg01135.html
- Chunyan >>> On 5/7/2014 at 06:17 PM, in message <536A0846.4C2 : 102 : 21807>, Chun Yan >>> Liu wrote: > My git-send-email died after sending 15 of 33. Resend again. > 1st 15 patches might appear twice. Sorry for that. > >>>> On 5/7/2014 at 05:54 PM, in message > <1399456476-10786-1-git-send-email-cy...@suse.com>, Chunyan Liu > <cy...@suse.com> wrote: > > This patch series is to replace QEMUOptionParameter with QemuOpts, so that > > >> only >> one Qemu Option structure is kept in QEMU code. >> >> --- >> Changes to v26: >> * Following Eric's comment, backward split 2/33, 3/33. >> (repurpose qemu_opts_print first, add def_value_str to QemuOptDesc >> later). >> * Fix memory free in qemu_opts_append to solve iotest issue. 10/33 >> * Following Eric's comment, remove the end '.' in error message. And >> update >> qemu-iotests .out file. 12/33 >> * Following Eric's comment, fix memory free in vvfat.c 13/33 >> * Following Eric's comment, split qcow2 patch into two. 19/33, 20/33: >> export qemu_opt_find first, add qcow2 driver patch later. >> * rebase to git master >> >> All patches are also available from: >> https://github.com/chunyanliu/qemu/commits/QemuOpts >> >> >> Chunyan Liu (33): >> QemuOpts: move find_desc_by_name ahead for later calling >> QemuOpts: repurpose qemu_opts_print to replace >> print_option_parameters >> QemuOpts: add def_value_str to QemuOptDesc >> qapi: output def_value_str when query command line options >> QemuOpts: change opt->name|str from (const char *) to (char *) >> QemuOpts: move qemu_opt_del ahead for later calling >> QemuOpts: add qemu_opt_get_*_del functions for replace work >> QemuOpts: add qemu_opts_print_help to replace print_option_help >> QemuOpts: add conversion between QEMUOptionParameter to QemuOpts >> QemuOpts: add qemu_opts_append to replace append_option_parameters >> QemuOpts: check NULL input for qemu_opts_del >> change block layer to support both QemuOpts and QEMUOptionParamter >> vvfat.c: handle cross_driver's create_options and create_opts >> cow.c: replace QEMUOptionParameter with QemuOpts >> gluster.c: replace QEMUOptionParameter with QemuOpts >> iscsi.c: replace QEMUOptionParameter with QemuOpts >> nfs.c: replace QEMUOptionParameter with QemuOpts >> qcow.c: replace QEMUOptionParameter with QemuOpts >> QemuOpts: export qemu_opt_find >> qcow2.c: replace QEMUOptionParameter with QemuOpts >> qed.c: replace QEMUOptionParameter with QemuOpts >> raw-posix.c: replace QEMUOptionParameter with QemuOpts >> raw-win32.c: replace QEMUOptionParameter with QemuOpts >> raw_bsd.c: replace QEMUOptionParameter with QemuOpts >> rbd.c: replace QEMUOptionParameter with QemuOpts >> sheepdog.c: replace QEMUOptionParameter with QemuOpts >> ssh.c: replace QEMUOptionParameter with QemuOpts >> vdi.c: replace QEMUOptionParameter with QemuOpts >> vhdx.c: replace QEMUOptionParameter with QemuOpts >> vmdk.c: replace QEMUOptionParameter with QemuOpts >> vpc.c: replace QEMUOptionParameter with QemuOpts >> cleanup QEMUOptionParameter >> QemuOpts: cleanup tmp 'allocated' member from QemuOptsList >> >> block.c | 99 ++++---- >> block/cow.c | 52 ++-- >> block/gluster.c | 73 +++--- >> block/iscsi.c | 32 ++- >> block/nfs.c | 10 +- >> block/qcow.c | 72 +++--- >> block/qcow2.c | 259 ++++++++++---------- >> block/qed.c | 112 +++++---- >> block/qed.h | 3 +- >> block/raw-posix.c | 55 ++--- >> block/raw-win32.c | 38 +-- >> block/raw_bsd.c | 25 +- >> block/rbd.c | 61 +++-- >> block/sheepdog.c | 102 ++++---- >> block/ssh.c | 30 ++- >> block/vdi.c | 71 +++--- >> block/vhdx.c | 97 ++++---- >> block/vhdx.h | 1 + >> block/vmdk.c | 121 +++++----- >> block/vpc.c | 60 ++--- >> block/vvfat.c | 13 +- >> include/block/block.h | 7 +- >> include/block/block_int.h | 9 +- >> include/qemu/option.h | 53 +--- >> include/qemu/option_int.h | 4 +- >> qapi-schema.json | 5 +- >> qapi/opts-visitor.c | 10 +- >> qemu-img.c | 89 +++---- >> qmp-commands.hx | 2 + >> tests/qemu-iotests/049.out | 2 +- >> tests/qemu-iotests/061.out | 2 +- >> util/qemu-config.c | 4 + >> util/qemu-option.c | 588 > ++++++++++++++++++++------------------------- >> 33 files changed, 1033 insertions(+), 1128 deletions(-) > >