Eric Blake <ebl...@redhat.com> writes:
> On 05/13/2014 10:02 AM, Markus Armbruster wrote:
>> Completes the conversion to Error started in commit 015a103^..d5124c0.
>>
>> Cc: Josh Durgin <josh.dur...@inktank.com>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> block/rbd.c | 66
>> +++++++++++++++++++++++++++++++------------------------------
>> 1 file changed, 34 insertions(+), 32 deletions(-)
>>
>
>> @@ -285,6 +289,7 @@ static int qemu_rbd_set_conf(rados_t cluster, const char
>> *conf)
>> static int qemu_rbd_create(const char *filename, QEMUOptionParameter
>> *options,
>> Error **errp)
>> {
>> + Error *local_err = NULL;
>> int64_t bytes = 0;
>> int64_t objsize;
>> int obj_order = 0;
>> @@ -301,7 +306,7 @@ static int qemu_rbd_create(const char *filename,
>> QEMUOptionParameter *options,
>> if (qemu_rbd_parsename(filename, pool, sizeof(pool),
>> snap_buf, sizeof(snap_buf),
>> name, sizeof(name),
>> - conf, sizeof(conf)) < 0) {
>> + conf, sizeof(conf), &local_err) < 0) {
>> return -EINVAL;
>
> Doesn't this leak local_err?
error_propagate() missing, will fix, thanks!
