On 06.05.2014 12:19, Kevin Wolf wrote:
The immediately visible effect of this patch is that it fixes committing
a temporary snapshot to its backing file. Previously, it would fail with
a "permission denied" error because bdrv_inherited_flags() forced the
backing file to be read-only, ignoring the r/w reopen of bdrv_commit().
The bigger problem this releaved is that the original open flags must
actually only be applied to the temporary snapshot, and the original
image file must be treated as a backing file of the temporary snapshot
and get the right flags for that.
Reported-by: Jan Kiszka <jan.kis...@web.de>
Signed-off-by: Kevin Wolf <kw...@redhat.com>
---
block.c | 34 +++++++++++++++++++---------------
include/block/block.h | 2 +-
tests/qemu-iotests/051 | 4 ++++
tests/qemu-iotests/051.out | 10 ++++++++++
4 files changed, 34 insertions(+), 16 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>