On Mon, May 05, 2014 at 10:02:55PM +0200, Hervé Poussineau wrote: > Le lun. 05 mai 2014 10:01:10 CEST, Michael S. Tsirkin a écrit : > >On Sat, May 03, 2014 at 10:39:37PM +0200, Hervé Poussineau wrote: > >>Ping. > >> > >>Le 22/04/2014 23:00, Hervé Poussineau a écrit : > >>>This is a guest-triggerable error, as seen when using Xenix 2.3.4. > >>>Replace hw_error by LOG_UNIMPL, so that guests have at least a chance to > >>>continue. > >>> > >>>Signed-off-by: Hervé Poussineau <hpous...@reactos.org> > > > >Is it just "a chance" or does Xenix actually work well with this > >applied? > > Yes, > With this patch, I can install and use Xenix 2.3.4a without any problem. > I can also start installation of Xenix 2.3.4q, but it fails due to > not finding an hard disk. > > Regards, > > Hervé
Thanks! I'll pick this patch up when I'm back online. > > > > > >>>--- > >>> hw/intc/i8259.c | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>>diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c > >>>index c6f248b..a069d04 100644 > >>>--- a/hw/intc/i8259.c > >>>+++ b/hw/intc/i8259.c > >>>@@ -265,7 +265,8 @@ static void pic_ioport_write(void *opaque, hwaddr > >>>addr64, > >>> s->init4 = val & 1; > >>> s->single_mode = val & 2; > >>> if (val & 0x08) { > >>>- hw_error("level sensitive irq not supported"); > >>>+ qemu_log_mask(LOG_UNIMP, > >>>+ "i8259: level sensitive irq not > >>>supported\n"); > >>> } > >>> } else if (val & 0x08) { > >>> if (val & 0x04) { > >>> > > >