>>> On 4/30/2014 at 12:30 AM, in message <535fd3b6.6020...@redhat.com>, Eric
>>> Blake
<ebl...@redhat.com> wrote:
> On 04/29/2014 03:10 AM, Chunyan Liu wrote:
> > Currently this function is not used anywhere. In later patches, it will
> > replace print_option_parameters. To avoid print info changes, change
> > qemu_opts_print from fprintf stderr to printf to keep consistent with
> > print_option_parameters, remove last printf and print size/number with
> > opt->value.uint instead of opt->str.
> >
> > Signed-off-by: Chunyan Liu <cy...@suse.com>
> > ---
> > util/qemu-option.c | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
>
> I would prefer to see this patch first, and 2/32 second; I'd also prefer
> to see the signature change (changing int to void return, and dropping
> dummy parameter) in this patch.
>
> > + } else if ((desc->type == QEMU_OPT_SIZE ||
> > + desc->type == QEMU_OPT_NUMBER) && opt) {
> > + printf("%s=%" PRId64 " ", desc->name, opt->value.uint);
>
> Shouldn't this be PRIu64, since you are printing an unsigned int?
print_option_parameters uses PRId64, so here using PRId64 too to keep
output unchanged. In qemu-iotests, there are some tests having negative
size, like 'size=-1024', changing to PRIu64 will cause such iotests failed.
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
>
