On 05/02/2014 05:26 AM, Markus Armbruster wrote: > Using error_is_set(errp) that way can sweep programming errors under > the carpet when we get called incorrectly with an error set. > > encrypted_bdrv_it() does it, because there's no way to make > bdrv_iterate() break its loop. Actually safe, because qmp_cont() > clears the error before the loop. Clean it up anyway: replace > bdrv_iterate() by bdrv_next(), break the loop on error. > > Replace both occurences, for consistency.
s/occurences/occurrences/ > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> Fixing up the commit message typo is trivial and doesn't alter the positive review. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
