On Fri, May 02, 2014 at 02:52:23PM +0400, Michael Tokarev wrote:
> Stefan Hajnoczi:
> > Implement g_thread_new() in terms of the deprecated g_thread_create().
> > The API was changed in glib 2.31.0.
> >
> > The compat function allows us to write modern code and avoid ifdefs.
>
> ACK. With one small nit:
>
> []
> > +#if !GLIB_CHECK_VERSION(2, 31, 0)
> > +static inline GThread *g_thread_new(const gchar *unused,
> > + GThreadFunc func,
> > + gpointer data)
> > +{
> > + GThread *thread = g_thread_create(func, data, TRUE, NULL);
> > + if (!thread) {
> > + g_error("g_thread_create failed");
> > + }
> > + return thread;
> > +}
> > +#endif
>
> About g_error():
>
> "This function will result in a core dump; don't use it for errors you expect.
> Using this function indicates a bug in your program, i.e. an assertion
> failure."
>
> I'm not sure if this is like an assertion failure, probably yes. But we
> should
> not, I think, dump core in this situation. Is there a glib function that does
> (fatal) error reporting but does NOT dump core?
I think that's what g_critical is intended for. It is more severe than
g_warning, but won't exit or abort the process.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
