Re: [Qemu-devel] [PATCH 2/4] Set eflags and cr0 prior to calling cpu_x86_load_seg_cache() in smm_helper.c.

[Richard Henderson]

On 04/30/2014 10:07 AM, Paolo Bonzini wrote:
> Il 30/04/2014 18:54, Richard Henderson ha scritto:
>> On 04/29/2014 01:38 PM, Kevin O'Connor wrote:
>>>      cpu_load_eflags(env, 0, ~(CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C |
>>>                                DF_MASK));
>>>      env->eip = 0x00008000;
>>> +    cpu_x86_update_cr0(env,
>>> +                       env->cr[0] & ~(CR0_PE_MASK | CR0_EM_MASK |
>>> CR0_TS_MASK |
>>> +                                      CR0_PG_MASK));
>>> +    cpu_x86_update_cr4(env, 0);
>>> +    env->dr[7] = 0x00000400;
>>> +    CC_OP = CC_OP_EFLAGS;
>>
>> Please place the CC_OP update immediately after cpu_load_eflags.
> 
> I was going to move it straight inside cpu_load_eflags in a follow-up patch.

Fair enough.


r~