Hi Chunyan, I haven't found enough time the last versions you've sent for review. I've buit your patch series and the final result builds nicely, but it fails the test 061, I haven't had the time to investigate it yet.
I'm leaving on vacation next Friday so I'll try to review all you patches before that. Regards... -- Dorileo On Tue, Apr 29, 2014 at 05:10:24PM +0800, Chunyan Liu wrote: > This patch series is to replace QEMUOptionParameter with QemuOpts, so that > only > one Qemu Option structure is kept in QEMU code. > > --- > Changes to v25: > * split v25 2/31 (add def_value_str to QemuOptDesc) into two patches: > 1st patch adds def_value_str, 2nd patch repurpose qemu_opts_print. > * update 4/32 qapi command line description. > * update 12/32 (change block layer to support both) according to > Eric's comments. > * small update to gluster.c > * rebase to latest code > > All patches are also available from: > https://github.com/chunyanliu/qemu/commits/QemuOpts > > > Chunyan Liu (31): > QemuOpts: move find_desc_by_name ahead for later calling > QemuOpts: add def_value_str to QemuOptDesc > QemuOpts: repurpose qemu_opts_print to replace print_option_parameters > qapi: output def_value_str when query command line options > QemuOpts: change opt->name|str from (const char *) to (char *) > QemuOpts: move qemu_opt_del ahead for later calling > QemuOpts: add qemu_opt_get_*_del functions for replace work > QemuOpts: add qemu_opts_print_help to replace print_option_help > QemuOpts: add conversion between QEMUOptionParameter to QemuOpts > QemuOpts: add qemu_opts_append to replace append_option_parameters > QemuOpts: check NULL input for qemu_opts_del > change block layer to support both QemuOpts and QEMUOptionParamter > vvfat.c: handle cross_driver's create_options and create_opts > cow.c: replace QEMUOptionParameter with QemuOpts > gluster.c: replace QEMUOptionParameter with QemuOpts > iscsi.c: replace QEMUOptionParameter with QemuOpts > nfs.c: replace QEMUOptionParameter with QemuOpts > qcow.c: replace QEMUOptionParameter with QemuOpts > qcow2.c: replace QEMUOptionParameter with QemuOpts > qed.c: replace QEMUOptionParameter with QemuOpts > raw-posix.c: replace QEMUOptionParameter with QemuOpts > raw-win32.c: replace QEMUOptionParameter with QemuOpts > raw_bsd.c: replace QEMUOptionParameter with QemuOpts > rbd.c: replace QEMUOptionParameter with QemuOpts > sheepdog.c: replace QEMUOptionParameter with QemuOpts > ssh.c: replace QEMUOptionParameter with QemuOpts > vdi.c: replace QEMUOptionParameter with QemuOpts > vhdx.c: replace QEMUOptionParameter with QemuOpts > vmdk.c: replace QEMUOptionParameter with QemuOpts > vpc.c: replace QEMUOptionParameter with QemuOpts > cleanup QEMUOptionParameter > > Michael Buesch (1): > slirp/smb: Move ncalrpc directory to tmp > >
