On 04/28/2014 12:37 PM, Jeff Cody wrote: > This allows qemu-img to print out version information, without > needing to print the long help wall of text. > > While there, perform some minor whitespace cleanup, and remove the > unused option_index variable in the call to getopt_long(). > > Reported-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Jeff Cody <jc...@redhat.com> > --- > qemu-img.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index d884324..96f4463 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -33,6 +33,9 @@ > #include "block/qapi.h" > #include <getopt.h> > > +#define QEMU_IMG_VERSION "qemu-img version " QEMU_VERSION \ > + ", Copyright (c) 2004-2008 Fabrice Bellard\n"
Is it worth listing 2014 in the copyright blurb? Then again, since Fabrice hasn't made a contribution in years, who would be the logical listing as the owner for any newer copyright year? "Copyright 2004-2014 Fabrice Bellard et. al"? But in the context of this patch, you just moved an existing string - any changes to the string necessarily would be in a separate patch (if at all), so it doesn't affect my review. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
