Am 28.04.2014 20:55, schrieb Leandro Dorileo: > ping? > > > On Tue, Mar 25, 2014 at 10:27:19AM -0300, Leandro Dorileo wrote: >> Cover basic aspects and API usage for QemuOpt. The current implementation >> covers the API's planned to be changed by Chunyan Liu in his >> QEMUOptionParameter >> replacement/cleanup job. >> >> Other APIs should be covered in future improvements. >> >> Signed-off-by: Leandro Dorileo <l...@dorileo.org> >> Reviewed-by: Eric Blake <ebl...@redhat.com> >> --- >> tests/Makefile | 3 + >> tests/test-qemu-opts.c | 455 >> +++++++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 458 insertions(+) >> create mode 100644 tests/test-qemu-opts.c
I don't spot any test API or style issues; not familiar enough with QemuOpts to judge the tests though. Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
