On 04/24/2014 02:35 AM, poletaev wrote: > There is a set of test, that checks QEMU CPU for similar behavior with real > hardware (http://roberto.greyhats.it/projects/pills.html). Test > reg/pill2579.c can detect, that program is execute in emulated environment. > It is related with behavior of rcl instruction. If the number of shifted > bits more than 1, OF of eflags become undefined. Real CPUs does not change > OF, if it is undefined. QEMU do it anyway. > > Emulated program can execute that test and after that can understand > environment not real. > >
Your patch came through whitespace munged: > > Signed-off-by: Dmitry Poletaev <observerc...@gmail.com> > > > > diff --git a/target-i386/shift_helper_template.h > b/target-i386/shift_helper_template.h > > index cf91a2d..d5bd321 100644 > > --- a/target-i386/shift_helper_template.h > > +++ b/target-i386/shift_helper_template.h > > @@ -64,8 +64,10 @@ target_ulong glue(helper_rcl, SUFFIX)(CPUX86State *env, > target_ulong t0, > > } > > t0 = res; > No one can apply this patch as sent. Please try again, and use http://wiki.qemu.org/Contribute/SubmitAPatch for ideas on how to properly send patches via 'git send-email' (a good test for correct settings: send the patch to yourself first, and see if you can get 'git am -3' to apply the patch into your local copy of qemu.git). > } > > > > This patch improve correctness of emulator behavior. Any text that is not part of the patch proper belongs up front in either the commit message, or between the --- separator after the signed-off-by and the actual patch, and not at the bottom after the patch content. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
