Am 22.04.2014 15:56, schrieb Eduardo Otubo: > > > On 04/14/2014 03:00 PM, Eduardo Otubo wrote: >> Signed-off-by: Felix Geyer <de...@fobos.de> >> Signed-off-by: Eduardo Otubo <ot...@linux.vnet.ibm.com> > > Sorry, Peter, you mean this one? > Should I remove Acked-by? I had other patches with Acked-by merged with > no problems before.
Apart from the issue of the Git tree [1] diverging from the patches, your Signed-off-by should be last. There's nothing particularly wrong with Acked-by otherwise, except that it's not adding any information over Signed-off-by, and when used last may cause confusion. Cheers, Andreas [1] https://github.com/otubo/qemu/commits/seccomp -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
