Hi,
I found some more time to work on this. However, I'm not sure I
understand the purpose of compat property:
I noticed that the only place it's set is in PC_COMPAT_1_3 (is this
what you meant by older devices?),
I guess same setting for FS mouse and kbd should be added there as well.
The switch statement in usb_tablet_initfn selects between two
descriptor structures, however, these structures are almost identical
with the sole exception of .high field being set in the HS version
(desc_tablet2).
So changing the switch statement to:
if (us->usb_version < 2)
dev->usb_desc->high = NULL;
should be OK for all usb hid devices, right?
When I dug some more I found only few places where the .high filed is
read, all in hw/usb/desc.c.
It seems to be used to determine speed capability (when attaching) and
some USB3 properties.
Connecting both devices to system with only a UHCI controller seems to work OK.
Am I missing something or is the only purpose of the switch to avoid
set but unused field?
I noticed that bcdUSB is unconditionally reported as 2.0 because of
the desc_msos_suspend, so the devices report as USB2.0 anyway.
thanks,
Jan
On Mon, Apr 7, 2014 at 4:02 AM, Gerd Hoffmann <kra...@redhat.com> wrote:
> On Do, 2014-04-03 at 01:27 -0400, Ján Veselý wrote:
>> ping2
>>
>> is there anything I can do to help these patches get merged?
>
> Well, v2 is a step into the right direction but not complete yet. The
> usb_ver property hasn't any effect for mouse and keyboard. Also we'll
> need a compat property so older machine types continue to have usb1
> mouse+keyboard.
>
> The compat property stuff is a bit tricky so my plan was to just do that
> myself, but I havn't found the time yet.
>
> If you wanna tackle the challenge have a look at
> 427e3aa151c749225364d0c30640e2e3c1756d9d (tablet patch). keyboard+mouse
> need to do the same.
>
> Also some cleanups can be done, such as moving the "switch
> (us->usb_version) { ... }" from usb_tablet_initfn to usb_hid_initfn to
> avoid duplicating it.
>
> cheers,
> Gerd
>
>
