On 04/02/2014 09:16 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu>
> ---
>  Makefile       |   24 ++++++++++++++++++------
>  tests/Makefile |   20 ++++++++++++++++----
>  2 files changed, 34 insertions(+), 10 deletions(-)

Reviewed-by: Eric Blake <ebl...@redhat.com>

> +     $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts \
> +             $(PYTHON) $(SRC_PATH)/tests/qapi-schema/test-qapi.py \
> +             <$^ \
> +             >$*.test.out \
> +             2>$*.test.err; \

I probably would have merged these three lines, but that's cosmetic and
doesn't affect my review.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to