On 03/28/2014 08:19 AM, Peter Maydell wrote:
> On 20 March 2014 19:21, Michael Roth <mdr...@linux.vnet.ibm.com> wrote:
>> Could it be as simple as this?:
>>
>> diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
>> index 9734ab0..a70482e 100644
>> --- a/scripts/qapi-commands.py
>> +++ b/scripts/qapi-commands.py
>> @@ -99,7 +99,7 @@ bool has_%(argname)s = false;
>> argname=c_var(argname), argtype=c_type(argtype))
>> else:
>> ret += mcgen('''
>> -%(argtype)s %(argname)s;
>> +%(argtype)s %(argname)s = {0};
>> ''',
>> argname=c_var(argname), argtype=c_type(argtype))
>
> Well, clang doesn't complain about this syntax, and it
> fixes the warnings about bools (which is good, because
> there was a genuine bug in dma-helpers.c that was hiding
> in amongst these other similar warnings...)
>
> Tested-by: Peter Maydell <peter.mayd...@linaro.org>We uncovered a real bug that would be fixed by this patch: https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg01745.html Is it worth cleaning this up into a formal submission and cc'ing qemu-stable and/or trying for the 2.0 release? If made formal, feel free to add: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
