On 04/10/2014 07:09 PM, Fam Zheng wrote: > On Thu, 04/10 19:36, Max Reitz wrote: >> As speed is an optional parameter for the QMP block-commit command, it >> should be set to 0 if not given (as it is undefined if has_speed is >> false), that is, the speed should not be limited. >> >> Signed-off-by: Max Reitz <mre...@redhat.com> >> Reviewed-by: Eric Blake <ebl...@redhat.com> >> --- >> This patch was previously part of the "qemu-img: Implement commit like >> QMP" series, but as this is a general bugfix, it has been separated. >> --- > > Reviewed-by: Fam Zheng <f...@redhat.com> > > The (generated) caller qmp_marshal_input_block_commit() actually leaves speed > uninitialized, so we're not safe without this patch:
> I'm wondering what the reason is to initialize pointers (like base and device) > while leaving int64_t values uninitilized in the code generator? Because no one has applied this patch yet: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg04224.html -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
