Re: [Qemu-devel] [PATCH 4/5] hw/net/stellaris_enet: Correctly implement the TR and THR registers

[Dr. David Alan Gilbert]

* Peter Maydell (peter.mayd...@linaro.org) wrote:

<snip>

> @@ -338,9 +347,11 @@ static void stellaris_enet_write(void *opaque, hwaddr 
> offset,
>      case 0x2c: /* MTXD */
>          s->mtxd = value & 0xff;
>          break;
> +    case 0x38: /* TR */
> +        stellaris_enet_send(s);
> +        break;

Shouldn't that be something like:

   if (value & 1) {
       stellaris_enet_send(s);
   }

Dave
>      case 0x30: /* MRXD */
>      case 0x34: /* NP */
> -    case 0x38: /* TR */
>          /* Ignored.  */
>      case 0x3c: /* Undocuented: Timestamp? */
>          /* Ignored.  */
> -- 
> 1.9.0
> 
> 
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK