Eric Blake writes: > On 04/01/2014 07:46 AM, Lluís Vilanova wrote: >>> The formatting in Benoît's series was a little nicer aesthetically: >> >>> +Inclusion loop detected with file: multi_file_loop_include.json >>> +Path to the broken include is: >>> + multi_file_loop_include.json >>> + multi_loop.json >> >>> Furthermore, it had the benefit of using the spelling provided by the >>> user, rather than the absolute path to the files. You want to track >>> canonical paths for detecting the loop, but do NOT want to report >>> absolute paths back to the user - instead, it's nicer to report back the >>> names as they spelled it. >> >> I think it's better reporting absolute paths, otherwise the user has to >> mentally >> keep track of the relative paths to get to the file.
> If you display the entire chain of paths that you opened as spelled by > the user, the user shouldn't have that hard a time finding the right > file. Furthermore, I seriously doubt we will be including files from > very many subdirectories in our use of this feature - the error is there > to aid a developer adding a new include, and won't ever trigger in > normal usage. If a developer triggers the error, they KNOW that the > error was caused by the very file that they were working on. Ok, then I can send a v8 with that change. Please check v7 to see if there are more changes required. Thanks, Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth
