On Mon, Mar 31, 2014 at 02:45:49PM +0200, Markus Armbruster wrote:
> Gerd Hoffmann <kra...@redhat.com> writes:
>
> >> + if (!(s->handler->mask & (INPUT_EVENT_MASK_REL |
> >> + INPUT_EVENT_MASK_ABS))) {
> >> + monitor_printf(mon, "Input device '%s' is not a mouse",
> >> + s->handler->name);
> >
> > That should be error_report (I think, Markus?).
>
> Yes, please. Same for the "Mouse at given index not found\n" message
> further down. Note that error_report() does *not* want \n.
Ok, thanks.
I just followed the other monitor_printf() usage for consistency. v2 sent.
>
> >
> > Otherwise the patch is fine.
> >
> > cheers,
> > Gerd
