On 01/05/2010 11:04 AM, Gerd Hoffmann wrote:
Hi,
- .driver = "virtio-console-pci",
+ .driver = "virtio-serial-pci",
I don't think we can eliminate the virtio-console-pci device name. If
someone used -writeconfig and -virtconsole in 0.12, this change would
break their written config files.
It wouldn't. virtio-console-pci was never fully converted to qdev
because of the multichannel work in flight. Thus you can't create a
functional device using '-device virtio-console-pci,<properties>'
because the driver lacks a chardev property.
Ah, okay.
Minor nit, this comment is no longer needed.
The whole function is a nasty hack which needs to go away. The
RightWay[tm] is to use a chardev property instead of this function.
So the comment is still correct. Maybe some rewording is helpful
though to make this more clear as the comment got a big bunch of
review comments already ;)
Okay, then a small rewording with that point would be helpful. It
wasn't clear to me that the function should become a property.
cheers,
Gerd
