Am 27.03.2014 14:03, schrieb Alexey Kardashevskiy:
> On 03/25/2014 01:40 PM, Anton Blanchard wrote:
>> 970 CPUs have PMC7/8. Create gen_spr_970 to avoid replicating
>> it 3 times, and simplify the existing code.
>>
>> Signed-off-by: Anton Blanchard <an...@samba.org>
>> ---
>> target-ppc/translate_init.c | 89
>> ++++++++++++++++++++-------------------------
>> 1 file changed, 39 insertions(+), 50 deletions(-)
>>
>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
>> index 273e37d..50b2603 100644
>> --- a/target-ppc/translate_init.c
>> +++ b/target-ppc/translate_init.c
>> @@ -6747,12 +6747,13 @@ static void gen_spr_book3s (CPUPPCState *env)
>> 0x00000000);
>> }
>>
>> -static void init_proc_970 (CPUPPCState *env)
>> +static void gen_spr_970 (CPUPPCState *env)
>> {
>> - gen_spr_ne_601(env);
>> - gen_spr_book3s(env);
>> - /* Time base */
>> - gen_tbl(env);
>> + spr_register(env, SPR_HIOR, "SPR_HIOR",
>
>
> + spr_register(env, SPR_HIOR, "HIOR",
>
> Can we please not add SPR_ in string name? Thanks.
As far I see, this is only being moved around, not added here.
If this is not user ABI, feel free to first drop it, then move it.
Similarly, adding the new ones in a third step would make review and
bisection easier.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
