>> + if (!s->header_mismatch) { >> + error_report("unknown cookie id\n"); >> + } > Do we need to set s->header_mismatch = true to prevent flooding logs? > >> + return -1; >> + } >> + } >> + session = (uint32_t *) (buf + s->session_offset); >> + if (ldl_be_p(session) != s->rx_session) { >> + if (!s->header_mismatch) { >> + error_report("session mismatch"); >> + } > Same here.
Just reviewed it - it is set one level up in the send function. Probably wrong place to set it, makes the code not very readable. A.