Sorry for late.
 
> 
> > @@ -161,6 +171,11 @@ int cache_insert(PageCache *cache, uint64_t addr,
> const uint8_t *pdata)
> >      /* actual update of entry */
> >      it = cache_get_by_addr(cache, addr);
> >
> > +    if ((it->it_data != NULL) && (it->it_age +
> > +        CACHED_PAGE_LIFETIME > current_age)) {
> > +        /* the cache page is fresh, don't replace it */
> 
> Should we add a counter for this "misses"?  It is a question to know how
> much it happens.
expose the rate of xbzrle cache miss to end user.

> 
> BTW, do you have any benchmark/numbers showing that this is a good idea?
> 
> Thanks, Juan.

Best regards,
-Gonglei

Reply via email to