On 17 March 2014 22:17, Andreas Färber <afaer...@suse.de> wrote: > Am 17.03.2014 12:55, schrieb riku.voi...@linaro.org: > > From: Riku Voipio <riku.voi...@linaro.org> > > > > some people get numerous unimplemented capget/capset warnings. Since qemu > > linux-user is not secure to begin with, just skip the system call > > warning for now. Proper capset/capget to be added in Qemu 2.1 > > "QEMU". Drop "qemu" above? >
Well at the moment I'm planning to drop the whole patch over Peter's implementation of capset/captget: http://patchwork.ozlabs.org/patch/330912/ > > Since Peter specifically mentioned to you that this is what the SUSE > tree does, it would be only fair to attribute this change to Alex as > patch author in some way, be it Signed-off-by, From or Suggested-by: > > > https://github.com/openSUSE/qemu/commit/b0817614daa8594bcc10dff88b384027d00deb1f > > Note that we only seemed to skip the warning for capget. > If you think implementing capset/capget this close to 2.0 release is too risky, I can revert to this patch - I'll then set Alex as the author. Riku > > Regards, > Andreas > > > --- > > linux-user/syscall.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > > index e404a32..4bfa3db 100644 > > --- a/linux-user/syscall.c > > +++ b/linux-user/syscall.c > > @@ -7677,9 +7677,9 @@ abi_long do_syscall(void *cpu_env, int num, > abi_long arg1, > > unlock_user(p, arg1, ret); > > break; > > case TARGET_NR_capget: > > - goto unimplemented; > > + goto unimplemented_nowarn; > > case TARGET_NR_capset: > > - goto unimplemented; > > + goto unimplemented_nowarn; > > case TARGET_NR_sigaltstack: > > #if defined(TARGET_I386) || defined(TARGET_ARM) || defined(TARGET_MIPS) > || \ > > defined(TARGET_SPARC) || defined(TARGET_PPC) || > defined(TARGET_ALPHA) || \ > > > > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >
